Onderwerp: Squid radius authenticator bug fix
Datum: Mon, 22 Jan 2001 17:28:37 +0100
Van: Klaus Weidner <kw@w-m-p.com>
Antwoord-naar: Klaus Weidner <kw@w-m-p.de>
Aan: selm@cistron.nl

Hello Marc,

thanks for your squid radius authenticator - I needed to fix a small bug
before it would work, which probably affects everyone with Intel byte
order.

The assignment of 'auth->length' erroneously used 'htonl' instead of
'htons' to assign a 16-bit value. The symptom was that the radius server
ignored the requests, because they had zero length according to the
data header.

Bye,

Klaus

Here's the patch:

--- squid_rad_auth.c    2001/01/22 14:32:07     1.1
+++ squid_rad_auth.c    2001/01/22 16:19:13
@@ -505,7 +505,7 @@
                ptr += 4;
                total_length += 6;

-               auth->length = htonl(total_length);
+               auth->length = htons(total_length);

                sin = (struct sockaddr_in *) &saremote;
                memset (sin, 0, sizeof (saremote));