Re: squid-2.0.RELEASE: Authentication issues [patch]

Bert Driehuis wrote:

> I do agree such features need a good hard look, since they make
> the code more complex and harder to document and maintain.

This time the issue is on a higher plane.

The actual code is very simple:

    /* append Authorization if known in URL, not in header and going
direct */
    if (!httpHeaderHas(hdr_out, HDR_AUTHORIZATION)) {
        if (!request->flags.proxying && *request->login) {
            httpHeaderPutStrf(hdr_out, HDR_AUTHORIZATION, "Basic %s",
                    base64_encode(request->login));
        }
    }

The implications of the use of such a feature is the big issue here.

/Henrik
Received on Tue Jul 29 2003 - 13:15:54 MDT