Re: cbdata_unlock in fs/*/*io*.c

Henrik Nordstrom wrote:

> And when the callback is called
>
> callback = struct->callback;
> their_data = struct->callback_data;
> struct->callback = NULL;
> struct->callback_data = NULL;
> if (cbdataValid(their_data))
> callback(parameters, ... , their_data);
> else /* if aborts not expected nor handled gracefully here */
> alert that the callback failed because the caller has gone away

I am only too tired. After all this (or actually somewhere after the
cbdataValid check, but last is simplest) there should obviously be a
cbdataUnlock(their_data) call...

/Henrik
Received on Fri Apr 21 2000 - 17:11:54 MDT