Validation code.

I think there is a race in storeCleanup.

I found a race between writing a swapfile and checking the files size while
doing the basic bits of the background checker. I think the same race could
occur in StoreCleanup.

the Cleanup code iterations through the swap dirs, through each storeentry.
However new storeentries are able to be written as soon as the Log/Directory
have been parsed into memory.

so the cleanup code could that calls doublecheck could call it on a new file
being written, thus causes a problem.

Anyway the doublecheck code is only called on -S as per the previous
commandline parameters. I've made the -S warning clearer - that it's for
debugging purposes only.

Finally is there any reason the storeCleanup code can't be part of the
rebuild? Now the disk checking is a background task, the Cleanup routine
just counts the file sizes and sets the VALIDATED bit.

Rob
Received on Sat Nov 25 2000 - 16:04:08 MST