Re: Validation code.

----- Original Message -----
From: "Duane Wessels" <wessels@squid-cache.org>
To: "Robert Collins" <robert.collins@itdomain.com.au>
Cc: <squid-dev@squid-cache.org>
Sent: Friday, December 01, 2000 10:15 AM
Subject: Re: Validation code.

>
>
> On Fri, 1 Dec 2000, Robert Collins wrote:
>
> > > The being-written entry should have ENTRY_VALIDATED set, right?
> > >
> > > storeCleanup() skips entries with ENTRY_VALIDATED set.
> > >
> > > Duane W.
> > >
> > >
> >
> > Maybe so... I reused storeCleanup as the basis for the simple background check. And it was consistently releasing everything I
> > downloaded if the background check hit it before SWAP_OUT occured. Perhaps VALIDATED is set when SWAP_OUT is? I'll go look.
>
> ENTRY_VALIDATED is set in storeCreateEntry(), so I think the bit
> should be set regardless of swapping out (for a new StoreEntry that
> wasn't read from the swap.state).
>
>

Yes I just went and looked. Maybe I'm, losing it...

I've found my confusion - sorry for the noise...

When I built the backgroundcheck I needed to check for !ENTRY_VALIDATED. So I was checking every entry. As you say storeCleanup has
the reverse logic and is fine.

End of dead-end path...

Rob
Received on Thu Nov 30 2000 - 16:20:16 MST