seen_offset vs copy_offset

From: Adrian Chadd <adrian@dont-contact.us>
Date: Mon, 25 Dec 2000 00:25:20 +0800

Hi,

Can I please get someone to sanity check this?

I'm looking at seen_offset vs copy_offset in the store client code.

As far as I can tell, seen_offset is used to limit calling
the store client completion callback even if some data is
ready to be returned.

client_side.c uses this in a coule of places - for example in
clientCacheHit() - if size bytes have been read from
http->out.offset but we're still waiting for the rest
of the reply headers, we set seen_offset to http->out.offset + size.
We still have the data, but it seems that this code throws
the data away and re-reads it again ..

Can someone familiar with the black magick in the storage manager
please tell me whether (a) this is true, and (b) there is a real
need to have this in the code, vs filling the remainder of
the buffer (ie copy into buf + size, total byte length bufsize - size)..

?

Merry Christmas!

Adrian

-- 
Adrian Chadd			"Here's five for the cake, and
<adrian@creative.net.au>	  five to buy a clue."
				    - Ryan, Whatever it Takes
Received on Sun Dec 24 2000 - 09:25:29 MST

This archive was generated by hypermail pre-2.1.9 : Tue Dec 09 2003 - 16:13:06 MST