RE: PATCH: bugfix for splaytree_auth config dump via cachemgr

This is not as good as it should (or could) be.
In the future we might add more flags, so assuming
data->names==NULL implies REQUIRED is broken.

-- 
	ing. Francesco Chemolli
	Unicredit Servizi Informativi
> -----Original Message-----
> From: Robert Collins [mailto:robert.collins@itdomain.com.au]
> Sent: Tuesday, January 09, 2001 12:18 PM
> To: squid-dev@squid-cache.org
> Subject: PATCH: bugfix for splaytree_auth config dump via cachemgr
> 
> 
> Caught this while testing digest auth's dump function. Can it 
> please go into head.
> 
> Rob
> 
> Index: acl.c
> ===================================================================
> RCS file: /cvsroot/squid/squid/src/acl.c,v
> retrieving revision 1.1.1.3.12.26.2.9.2.10
> diff -u -r1.1.1.3.12.26.2.9.2.10 acl.c
> --- acl.c       2001/01/08 14:31:18     1.1.1.3.12.26.2.9.2.10
> +++ acl.c       2001/01/09 11:04:01
> @@ -2227,7 +2227,13 @@
>       * a wordlist this way costs Sum(1,N) iterations. For instance
>       * a 1000-elements list will be filled in 499500 iterations.
>       */
> -    splay_walk(data->names, aclDumpUserListWalkee, &wl);
> +    if (data->names)
> +        splay_walk(data->names, aclDumpUserListWalkee, &wl);
> +    else
> +        /*
> +         * special case for REQUIRED
> +         */
> +        wordlistAdd(&wl, "REQUIRED");
>      return wl;
>  }
>