Re: Squid CygWin enhancement

Hi Robert,

Il 01.41 27/04/2001 Robert Collins ha scritto:

>----- Original Message -----
>From: "Robert Collins" <robert.collins@itdomain.com.au>
>To: <squid-dev@squid-cache.org>; "Guido Serassio" <serassio@libero.it>
>Sent: Friday, April 27, 2001 8:25 AM
>Subject: Re: Squid CygWin enhancement
>
>
> > ----- Original Message -----
> > >
> > > >1) in defines.h, you are defining _WIN_OS_WIN32S/9X/NT/2K - are
>these
> > > >constants tested against the OS? If so should we use the
>equivalents
> > > >from windows.h (or files that windows.h auto-includes) ?
> > >
> > > These defines are my arbitrary defines, taken from a my code running
> > on 9x,
> > > NT and 2000 with
> > > the GetOSVersion function. There is no useful defines about OS
> > recognition
> > > on MS (or CygWin compatible) include files, so i think this code may
> > be rigth.
> > >
>
>These look similar
>
>#define VOS__BASE 0
>#define VOS__WINDOWS16 1
>#define VOS__PM16 2
>#define VOS__PM32 3
>#define VOS__WINDOWS32 4
>
>(from winver.h).
>
>We should not use arbitrary defines - while the current os's won't
>change, future maintainers won't know how to ID the next version..
>
>Rob

I think that there are some misunderstanding about this question:

The GetOSVersion function on win32.c gets the OS Version id from the
GetVersion system call, this id is a bit flag DWord, so after checking the
right bits, it returns an arbitrary value that I defined for my
convenience. After this, in the WIN32_Subsystem_Init function,
WIN32_OS_version is set to the returned value.
The problem is that all the value that I need are not available on winver.h:
There are only Win16 and Win32 value (PM group is for OS/2 Presentation
Manager), while I need at least 3 value for 9X, NT and W2K, because they
are very different in the networking section.

Guido

-
=======================================================
Serassio Guido
Via Albenga, 11/4 10134 - Torino - ITALY
Tel. : +39.011.610749
E-mail: serassio@interfree.it
            serassio@libero.it
WWW: http://serassio.interfree.it
Received on Fri Apr 27 2001 - 01:58:10 MDT