Re: any idea? (acl.c broken for ASN)

Oops.. fixed. It was only meant to remove the SRC_RTT case, not the
rest...

--
Henrik
Andres Kroonmaa wrote:
>  The problem was introduced at around 18.Feb.01 with this mod (by hno):
>  http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/squid/squid/src/acl.c.diff?r1=1.21&r2=1.22&only_with_tag=MAIN
> 
> diff -u -r1.21 -r1.22
> --- acl.c       2001/02/09 19:52:05     1.21
> +++ acl.c       2001/02/18 11:18:47     1.22
> ..
> @@ -42,7 +42,9 @@
>  static void aclParseDomainList(void *curlist);
>  static void aclParseUserList(void **current);
>  static void aclParseIpList(void *curlist);
> +#if UNUSED_CODE
>  static void aclParseIntlist(void *curlist);
> +#endif
>  #if SQUID_SNMP
>  static void aclParseWordList(void *curlist);
>  #endif
> ..
> @@ -779,9 +787,11 @@
>         break;
>      case ACL_SRC_ASN:
>      case ACL_MAXCONN:
>      case ACL_DST_ASN:
> +#if SRC_RTT_NOT_YET_FINISHED
>      case ACL_NETDB_SRC_RTT:
>         aclParseIntlist(&A->data);
>         break;
> +#endif
>      case ACL_URL_PORT:
>      case ACL_MY_PORT:
>         aclParseIntRange(&A->data);
> 
>  To me, it looks like above #endif was misplaced. All acl types above will
>  fall through to aclParseIntRange() now. But then again, enclosing some
>  code with UNUSED_CODE sounds like it was intentional.
> 
>  Are we in the process of converting all intList params into intRange params,
>  or should I recover aclParseIntlist() ?
> 
> ------------------------------------
>  Andres Kroonmaa <andre@online.ee>
>  CTO, Microlink Online
>  Tel: 6501 731, Fax: 6501 708
>  Pärnu mnt. 158, Tallinn,
>  11317 Estonia