Re: Quoting Username/Password in authenticate.c

On Tue, Sep 11, 2001 at 07:40:54AM +0200, Henrik Nordstrom wrote:

> You can try the attached patch. It is a direct port of the old one.
> Completely untested, but not much have changed...

> Index: squid/src/authenticate.c
> --- squid/src/authenticate.c 2001/01/12 00:51:44 1.13.2.1
> +++ squid/src/authenticate.c 2001/09/11 05:32:25

[ ... ]

> @@ -96,12 +98,13 @@
> }
> r = xcalloc(1, sizeof(authenticateStateData));
> cbdataAdd(r, cbdataXfree, 0);
> + xstrncpy(r->user, rfc1738_escape(hashKeyStr(auth_user->hash), sizeof(r->user));

I've patched it (successfully), but when I compile it, gcc gives the
following errors:

----
gmake[2]: Entering directory `/home/andrew/alfred-current/squid/src'
gcc -g  -Wall -I. -I../include -I../include    -c -o authenticate.o authenticate.c
authenticate.c: In function `authenticateStart':
authenticate.c:101: incompatible type for argument 1 of `hashKeyStr'
authenticate.c:101: too many arguments to function `rfc1738_escape'
authenticate.c:101: syntax error before `;'
authenticate.c:107: warning: too few arguments for format
authenticate.c:107: syntax error before `)'
gmake[2]: *** [authenticate.o] Error 1
----
D'you reckon you could have a look at this?
TIA,
   - andrew
-- 
void signature () {
	cout << "Andrew Reid -- andrew.reid@plug.cx" << endl;
	cout << "Cell: +61 401 946 813" << endl;
	cout << "Quidquid latine dictum sit, altum viditur" << endl;
}