NTLM code question

From: Henrik Nordstrom <hno@dont-contact.us>
Date: Fri, 28 Sep 2001 09:48:22 +0200

While going thru the cbdata branch, my eyes fell on the following:

ntlm_auth.c:authenticateNTLMHandleplaceholder

    /* standard callback stuff */
    valid = cbdataValid(r->data);
    if (!valid) {
        debug(29, 1) ("AuthenticateNTLMHandlePlacheholder: invalid
callback data.\n");
        return result;
    }
    /* call authenticateNTLMStart to retry this request */
    debug(29, 9) ("authenticateNTLMHandleplaceholder: calling
authenticateNTLMStart\n");
    authenticateNTLMStart(r->auth_user_request, r->handler, r->data);
    cbdataDone(r->data);
    authenticateStateFree(r);
    return result;

Shouldn't the above error case free up things? Seems a bit odd to only
return, not freeing the cbdata or auth state.

--
Henrik
Received on Fri Sep 28 2001 - 01:47:42 MDT

This archive was generated by hypermail pre-2.1.9 : Tue Dec 09 2003 - 16:14:22 MST