Re: [squid-users] squid 2.5 latest snapshot

From: Henrik Nordstrom <hno@dont-contact.us>
Date: Sat, 27 Oct 2001 01:17:47 +0200

Think I have found what may be causing your problems. One of the recent
cleanups broke some odd assumptions on memory management for "invalid"
requests.

Try the attached patch or the 20011027 or later snapshot.

Regards
Henrik

Henrik Nordstrom wrote:
>
> Can you please get a stack trace of where it is failing?
>
> Regards
> Henrik Nordström
> Squid Hacker
>
> Edward wrote:
> >
> > Hi there!
> >
> > Can anyone who is using squid 2.5 latest snapshot, please tell me if there
> > are having problems where squid is failing?
> >
> > 2001/10/26 14:07:51| clientReadRequest: FD 115 Invalid Request
> > FATAL: Received Segment Violation...dying.
> > 2001/10/26 14:07:53| storeDirWriteCleanLogs: Starting...
> > 2001/10/26 14:07:53| WARNING: Closing open FD 20
> > 2001/10/26 14:07:53| WARNING: Closing open FD 22
> > 2001/10/26 14:07:53| Finished. Wrote 3537 entries.
> > 2001/10/26 14:07:53| Took 0.0 seconds (308074.2 entries/sec).
> > CPU Usage: 8.070 seconds = 3.040 user + 5.030 sys
> > Maximum Resident Size: 0 KB
> > Page faults with physical i/o: 433
> > Memory usage for squid via mallinfo():
> > total space in arena: 68 KB
> > Ordinary blocks: 1 KB 1 blks
> > Small blocks: 0 KB 0 blks
> > Holding blocks: 2024 KB 2 blks
> > Free Small blocks: 0 KB
> > Free Ordinary blocks: 66 KB
> > Total in use: 2025 KB 2978%
> > Total free: 66 KB 98%
> > 2001/10/26 14:07:56| Starting Squid Cache version 2.5-DEVEL for
> > i686-pc-linux-gn
> > u...
> > 2001/10/26 14:07:56| Process ID 17305
> > 2001/10/26 14:07:56| With 8192 file descriptors available
> > 2001/10/26 14:07:56| Performing DNS Tests...
> > 2001/10/26 14:07:56| Successful DNS name lookup tests...
> > 2001/10/26 14:07:56| DNS Socket created at 0.0.0.0, port 1029, FD 5
> > 2001/10/26 14:07:56| Adding nameserver 127.0.0.1 from squid.conf
> > 2001/10/26 14:07:56| Adding nameserver 200.50.68.5 from squid.conf
> > 2001/10/26 14:07:56| Adding nameserver 200.50.68.6 from squid.conf
> > 2001/10/26 14:07:56| Adding nameserver 205.214.192.201 from squid.conf
> > 2001/10/26 14:07:56| Adding nameserver 205.214.192.202 from squid.conf
> > 2001/10/26 14:07:56| Unlinkd pipe opened on FD 10
> > 2001/10/26 14:07:56| Swap maxSize 17203200 KB, estimated 1323323 objects
> > 2001/10/26 14:07:56| Target number of buckets: 66166
> > 2001/10/26 14:07:56| Using 131072 Store buckets
> > 2001/10/26 14:07:56| Max Mem size: 81920 KB
> > 2001/10/26 14:07:56| Max Swap size: 17203200 KB
> > 2001/10/26 14:07:56| Store logging disabled
> > 2001/10/26 14:07:56| Rebuilding storage in /cache0 (CLEAN)
> > 2001/10/26 14:07:56| Rebuilding storage in /cache1 (CLEAN)
> > 2001/10/26 14:07:56| Rebuilding storage in /cache2 (CLEAN)
> > 2001/10/26 14:07:56| Rebuilding storage in /cache3 (CLEAN)
> > 2001/10/26 14:07:56| Using Least Load store dir selection
> > 2001/10/26 14:07:56| Set Current Directory to /cache0
> > 2001/10/26 14:07:56| Loaded Icons.
> > 2001/10/26 14:07:56| Accepting HTTP connections at 0.0.0.0, port 3128, FD
> > 20.
> > 2001/10/26 14:07:56| Accepting ICP messages at 0.0.0.0, port 3130, FD 22.
> > 2001/10/26 14:07:56| Accepting SNMP messages on port 161, FD 23.
> > 2001/10/26 14:07:56| WCCP Disabled.
> > 2001/10/26 14:07:56| Ready to serve requests.
> > 2001/10/26 14:07:56| Done reading /cache1 swaplog (862 entries)
> > 2001/10/26 14:07:56| Done reading /cache3 swaplog (866 entries)
> > 2001/10/26 14:07:56| Done reading /cache0 swaplog (901 entries)
> > 2001/10/26 14:07:56| Done reading /cache2 swaplog (908 entries)
> > 2001/10/26 14:07:56| Finished rebuilding storage from disk.
> > 2001/10/26 14:07:56| 3537 Entries scanned
> > 2001/10/26 14:07:56| 0 Invalid entries.
> > 2001/10/26 14:07:56| 0 With invalid flags.
> > 2001/10/26 14:07:56| 3537 Objects loaded.
> > 2001/10/26 14:07:56| 0 Objects expired.
> > 2001/10/26 14:07:56| 0 Objects cancelled.
> > 2001/10/26 14:07:56| 0 Duplicate URLs purged.
> > 2001/10/26 14:07:56| 0 Swapfile clashes avoided.
> > 2001/10/26 14:07:56| Took 0.6 seconds (5695.3 objects/sec).
> > 2001/10/26 14:07:56| Beginning Validation Procedure
> > 2001/10/26 14:07:56| Completed Validation Procedure
> > 2001/10/26 14:07:56| Validated 3537 Entries
> > 2001/10/26 14:07:56| store_swap_size = 28128k
> > 2001/10/26 14:07:57| storeLateRelease: released 0 objects
> >
> > Thank you very much.
> >
> > Best regards,
> >
> > Edward Millington. BSc, Network+
> > (Systems Administrator)
> > Cariaccess Communications Ltd.
> > Palm Plaza
> > Wildey
> > St. Michael
> > Barbados
> > 1-246-430-7435
> > Fax : 1-246-431-0170
> > edward@cariaccess.com
> > www.cariaccess.com

Index: client_side.c
===================================================================
RCS file: /server/cvs-server/squid/squid/src/client_side.c,v
retrieving revision 1.555
diff -u -w -r1.555 client_side.c
--- client_side.c 2001/10/24 07:45:34 1.555
+++ client_side.c 2001/10/26 23:05:54
@@ -2439,11 +2439,14 @@
     size_t sock_sz = sizeof(conn->me);
 #endif
 
+ /* pre-set these values to make aborting simpler */
+ *prefix_p = NULL;
+ *method_p = METHOD_NONE;
+ *status = -1;
+
     if ((req_sz = headersEnd(conn->in.buf, conn->in.offset)) == 0) {
         debug(33, 5) ("Incomplete request, waiting for end of headers\n");
         *status = 0;
- *prefix_p = NULL;
- *method_p = METHOD_NONE;
         return NULL;
     }
     assert(req_sz <= conn->in.offset);
@@ -2451,11 +2454,6 @@
     inbuf = xmalloc(req_sz + 1);
     xmemcpy(inbuf, conn->in.buf, req_sz);
     *(inbuf + req_sz) = '\0';
-
- /* pre-set these values to make aborting simpler */
- *prefix_p = inbuf;
- *method_p = METHOD_NONE;
- *status = -1;
 
     /* Barf on NULL characters in the headers */
     if (strlen(inbuf) != req_sz) {
Received on Fri Oct 26 2001 - 17:26:06 MDT

This archive was generated by hypermail pre-2.1.9 : Tue Dec 09 2003 - 16:14:35 MST