Re: [PATCH] (fix digest) + store HHA1 digest hash rather than password

On Wed, 2003-02-05 at 17:51, Sean Burford wrote:
> Hi,
>
> The patch I mentioned in my previous message is attached.

Thank you for the patch Sean. I've used it in squid 2.5 to band-aid the
issue, but implemented the full TODO from the code for squid-3: the
credentials_ok field is now a per request field, so only the HA1created
field affects multiple requests. I've done some loose testing of this,
but if you have an active interest in using digest, I'd love to get some
more feedback on the behaviour in squid-3.

I've also merged in your updated digest helper patch for squid-3, after
a couple of minor corrections:
* You hadn't adjusted argv[1] to passwordfile in all cases, so -c
silently failed.
* plaintext passwords (no -c) can start with {HHA1} - so must not be
excluded.

Cheers,
and thanks.
Rob

-- 
GPG key available at: <http://users.bigpond.net.au/robertc/keys.txt>.