Re: Windows port merge - MS Visual C++ compatibility [PATCH]

On Sat, 2003-03-08 at 22:08, Guido Serassio wrote:
> Hi,
>
> This is the 6th of some splitted native Windows patches grouped by
> functionality.
>
> Native Windows port enhancements:
>
> - C++ fixes for MS Visual C++ compatibility, See this old squid-dev thread
> about:
> http://www.squid-cache.org/mail-archive/squid-dev/200211/0249.html

> - Some casting and prototypes fixes

 {
- cbdataFree ((clientReplyContext *)address);
+ clientReplyContext * tmp = (clientReplyContext *)address;
+ cbdataFree (tmp);
 }

This looks extraneous. What is the error that VS gives you? I'm
stripping this one out of what I'll merge into HEAD.

> - some little DNS sources changes for a better build process using MS
> Visual Studio.

Is there anyway we can avoid the whole file #ifdefs in VS ? I'm applying
this anyway, but as we get more modular, this is going to
become....annoying.

Can you enlarge on the TOS casts? They are going to affect all
platforms, I need to know what they are meant to achieve (i.e. why the
compilers implicit casting isn't enough).

Other than that, I'm merging them patches in now.

Rob

-- 
GPG key available at: <http://users.bigpond.net.au/robertc/keys.txt>.