Re: Windows port merge - Service support (part 1) [PATCH]

On Monday 21 April 2003 12.24, Guido Serassio wrote:

> - main.cc and protos.h: changed rotate_logs() and reconfigure()
> from static to global (needed by service functionality), added
> Windows platform info in cache.log

Another minor unrelated change in main.cc (but correct in context of
prior patches) opened a question on the integration of the nt port:

Exacly when is _SQUID_MSWIN_ defined?

If this is also defined when building using CYGWIN then the windows
port is perhaps a bit too intrusive in how/why it removes the daemon
mode of Squid. Probably this should be wrapped into a #ifdef
DAEMON_MODE instead, defined accordingly.

If you want to remove a feature then my preference is to add a
conditional define (and maybe even a configure option) for this
specific feature rather than relying on hardcoded platform defines.

Regards
Henrik
Received on Mon Apr 21 2003 - 07:15:55 MDT