Re: last changes in httpHeaderReset()

Hi,

On Sun, 25 May 2003 22:47:28 +0200
  Henrik Nordstrom <hno@marasystems.com> wrote:
>On Sunday 25 May 2003 19.52, Evgeny Kotsuba wrote:
>> Hi,
>>
>> It seems that last change in src\HttpHeader.c httpHeaderReset()
>> is not very good.
>>
>> Was:
>> ================================
>> int
>> httpHeaderReset(HttpHeader * hdr)
>> {
>> http_hdr_owner_type ho;
>> assert(hdr);
>> ho = hdr->owner;
>> ==================================
>> Now:
>> int
>> httpHeaderReset(HttpHeader * hdr)
>> {
>> http_hdr_owner_type ho = hdr->owner;
>> assert(hdr);
>> ho = hdr->owner;
>> ==================================
>
>
>While your code is what it should look like, this is nothing new. The
>code has lookes as "Was" above since the http_hdr_owner_type was
>introduced (27 May 1998).

I don't understood what you wrote about :-/
I see only bad change in 2.5s3 vs 2.5s2(or s1?)

  http_hdr_owner_type
      ho = hdr->owner;
      assert(hdr);
      ho = hdr->owner;

If hdr is NULL, then what will be in first ho = ?
And why double code for initialization of variable ho is better ?

SY,
Evgeny Kotsuba

___________________
Посмотрел "Матрицу-2" - не понравилось, зато поднял 40% на акциях РАО ЕЭС:
http://www.rambler.ru/nettrader/
Received on Mon May 26 2003 - 02:05:30 MDT