Re: Squid-2.5.STABLE5 still not ready

On Thu, 12 Feb 2004, Duane Wessels wrote:

> This change looks suspicious to me:
>
> @@ -199,11 +199,15 @@
> static void
> ipcacheAddEntry(ipcache_entry * i)
> {
> - hash_link *e = hash_lookup(ip_table, i->hash.key);
> + ipcache_entry *e = (ipcache_entry *) hash_lookup(ip_table, i->hash.key);
> if (NULL != e) {
> - /* avoid colission */
> - ipcache_entry *q = (ipcache_entry *) e;
> - ipcacheRelease(q);
> + /* avoid collision */
> + if (i->flags.negcached && !e->flags.negcached && e->expires > squid_curtime) {
> + /* Don't waste good information */
> + ipcacheFreeEntry(i);
> + return;
> + }
> + ipcacheRelease(e);
> }
> hash_join(ip_table, &i->hash);
> dlinkAdd(i, &i->lru, &lru_list);

Have now backed out this bad change. Hopefully this is the source of the
problem and there is no other stupid errors.

Thanks for the help.

I just got a report about another likely regression error however, this
time related to NTLM challenge reuses, so STABLE5 is still not ready but
we are getting very very close to a release candidate.

Regards
Henrik
Received on Thu Feb 12 2004 - 03:11:04 MST