Re: Developer for IPv6 Squid patch.

On Thu, 14 Apr 2005, Rafael Martinez Torres wrote:

> MANY-MANY TIMES ON A SOURCE-FILE. This become unreadable, since properly
> speaking, IPv6 does not provide any application funcionality, like modules
> snmp, wwcp...and your code is exhaustevely full of #ifdef INET6.

Indeed, and any IPv6 implementation relying on a lot of #ifdefs sprinkled
around in the code won't get into HEAD as it becomes a maintenance
nightmare to keep the code updated, and very error prone on changes.

Incremental merging of changes not depending on a lot of #ifdefs is highly
preferred. And also ensures reasonable continuation of the changes even if
one person can not finish them all.

> The drawback is you cannot "cvsmerge HEAD" before commit into main Squid
> Release, since this affects the
> prototypes on many routines on the HEAD branch.
>
> -idnsPTRLookup(const struct in_addr addr, IDNSCB *callback, void *data).
> +idnsPTRLookup(const struct IN_ADDR addr, IDNSCB *callback, void *data).

So then get this change into HEAD first. It is harmless and does not
obfuscate the code.

Regards
Henrik
Received on Thu Apr 14 2005 - 04:56:42 MDT