Re: cvs commit: squid3/src ACLIP.cc

From: Henrik Nordstrom <hno@dont-contact.us>
Date: Thu, 8 Sep 2005 20:48:09 +0200 (CEST)

On Wed, 7 Sep 2005 wessels@squid-cache.org wrote:

> Had a coredump where ACLIP::data was NULL. This patch avoids the
> NULL pointer dereference, but there might be another bug elsewhere that
> allows data to be NULL.

ACLs are allowed to be empty these days. This was changed during the code
sprint to make configuration consistent when there is empty acls.

From what I can tell the change you made should not make any difference.
SplayNode<V>::destroy already checks for NULL and should catch this, and
it is not a virtual method. But on the other hand the change does not hurt
either, just duplicates some code.

Do you have any additional information on the core dump?

Regards
Henrik
Received on Thu Sep 08 2005 - 12:48:11 MDT

This archive was generated by hypermail pre-2.1.9 : Sat Oct 01 2005 - 12:00:05 MDT