Re: 2.5.STABLE13 approaching

From: Henrik Nordstrom <henrik@dont-contact.us>
Date: Mon, 27 Feb 2006 16:55:16 +0100

mån 2006-02-27 klockan 14:51 +0100 skrev Guido Serassio:

> The problems are two:
>
> - The oddity of unused stateful helper

Which I have admittedly never really looked at..

> - For standard helpers, the displayed value is the length of the last
> request, and not now - time_when_last_request_was_sent

Are you sure? Hmm.. code confirms what you say. Changed by Duane
15-May-02..

revision 1.34.2.3
date: 2002/05/15 19:09:53; author: wessels; state: Exp; lines: +7 -5
MFC: Steve Bennett fixes for helper/redirector service time values.

- storeAppendPrintf(sentry, "avg service time: %d msec\n",
- hlp->stats.avg_svc_time);
+ storeAppendPrintf(sentry, "avg service time: %.2f msec\n",
+ (double) hlp->stats.avg_svc_time / 1000.0);

- tt = 0.001 * tvSubMsec(srv->dispatch_time, current_time);
+ tt = 0.001 * tvSubMsec(srv->dispatch_time,
+ srv->flags.busy ? current_time : srv->answer_time);

now to display just what you say, probably with good intentions.

So why do we want to change this back? Isn't it good to know how long
the response took? Never really saw that "idle" time as useful.

Regards
Henrik

Received on Mon Feb 27 2006 - 08:55:20 MST

This archive was generated by hypermail pre-2.1.9 : Tue Feb 28 2006 - 12:00:05 MST