Re: Download hanging

mån 2006-08-07 klockan 17:50 +0800 skrev Steven:

> Once an object reachs store_maxobjsize (in my case 128K), it falls through
> and eventually runs storeCheckCachable() and figures out that the object
> is not cachable. The problem here is that if all data has been sent to
> the client, there is nothing to kick the store entry into freeing the
> memory.

Makes sense.

> The attached patch is one solution.

Hmm. found the code not very obvious to follow here and your patch
didn't exacly improve this..

What do you think about having the call at the end of
storeCheckCachable() just after the object is marked uncacheable, or
perhaps better yet move that part of the logics up to storeSwapout
making the conditions easier to follow.

I.e. something like the attached variant of the patch.

Regards
Henrik