Re: Bug review request

Hi Henrik,

At 10.22 15/08/2006, Henrik Nordstrom wrote:

>On Mon, 2006-08-14 at 10:32 +0200, Guido Serassio wrote:
>
> > err->request = requestLink(request);
> >
> > But not always err->request is linked to a request, it could be a problem ?
>
>You have found places where err->request is assigned without a link?

In client_side.c at line 3932, 3943, 4073 and 4285 (not used code) I
can't see any err->request assignment.

In other places there are many assignment done using fwdFail() as you
noted previously.

> > > ->src_addr
> >
> > Some confusion here, sometimes:
> >
> > err->src_addr = conn->peer.sin_addr;
> > or err->src_addr = http->conn->peer.sin_addr;
> >
> > some other times:
> >
> > err->src_addr = request->client_addr;
> >
> > What is correct ?
>
>request when you have a request. The few places where errorCon is called
>before we have a request NULL can be passed, and the caller has to fill
>in the available details after as is done now.

OK.

> > In client_side.c (clientAccessCheckDone()) there is:
> >
> > if (http->conn->auth_user_request)
> > err->auth_user_request = http->conn->auth_user_request;
> > else if (http->request->auth_user_request)
> > err->auth_user_request = http->request->auth_user_request;
> >
> > where http is a clientHttpRequest.
>
>I think we always have request->auth_user_request now even on connection
>oriented auth. If not that should be easy to fix.

So like this ?

err->auth_user_request = request->auth_user_request;

Regards

Guido

-
========================================================
Guido Serassio
Acme Consulting S.r.l. - Microsoft Certified Partner
Via Lucia Savarino, 1 10098 - Rivoli (TO) - ITALY
Tel. : +39.011.9530135 Fax. : +39.011.9781115
Email: guido.serassio@acmeconsulting.it
WWW: http://www.acmeconsulting.it/
Received on Tue Aug 15 2006 - 14:46:36 MDT