Re: Squid 2.6 MinGW support patch for review

Hi Henrik,

At 00.35 04/09/2006, Henrik Nordstrom wrote:
>sön 2006-09-03 klockan 15:05 +0200 skrev Guido Serassio:
>
> > Here there is the Squid 2.6 MinGW support
> patch and the three new files needed.
>
>Looks OK to me. Only notable change outside win32 is the addition of a
>new result argument to ipcCreate(), unused except on win32. No problem.

OK, I will add some additional comment in the source before commit.

>But why these #ifndef:s around the C code?
>
>Index: lib/util.c
>
>+#ifndef UTIL_C
>+#define UTIL_C
>
>Index: src/comm.c
>
>+#ifndef COMM_C
>+#define COMM_C

They are needed by the FD<=> socket "magic" in
squid_mswin.h, I need to know when I'm compiling these files.

Any suggestion here is welcome :-)

Regards

Guido

-
========================================================
Guido Serassio
Acme Consulting S.r.l. - Microsoft Certified Partner
Via Lucia Savarino, 1 10098 - Rivoli (TO) - ITALY
Tel. : +39.011.9530135 Fax. : +39.011.9781115
Email: guido.serassio@acmeconsulting.it
WWW: http://www.acmeconsulting.it/
Received on Mon Sep 04 2006 - 01:04:18 MDT