Re: Squid 2.6 MinGW support patch for review

Hi,

At 02.32 05/09/2006, conon wrote:
> > >Ok. Then drop the #if / #endif, keeping only the #define and add a
> > >comment.
> > >
> > >The way it's done now looks like #include shielding, which it isn't.
> >
>Actually it is #include shielding providing a clean output during
>compile.
>It prevents them from being accidentally defined twice and giving a gcc
>warning - ... previously defined here ...
>
>Therefore isn't it technically correct ?

Sure, it's correct.

But as wrote Henrik, this is not #include shielding, only a sort of
"source tagging".

Regards

Guido

-
========================================================
Guido Serassio
Acme Consulting S.r.l. - Microsoft Certified Partner
Via Lucia Savarino, 1 10098 - Rivoli (TO) - ITALY
Tel. : +39.011.9530135 Fax. : +39.011.9781115
Email: guido.serassio@acmeconsulting.it
WWW: http://www.acmeconsulting.it/
Received on Tue Sep 05 2006 - 00:19:29 MDT