Re: [PATCH] Squid3 virtual-host httpd-accelerator fix

Oops, it appears I went a bit too fast:

mainParseOptions() has to be called before parseConfigFile() indeed, because
of the -f option to specify an alternate configuration file, but still: the
handling of the -V option was broken.

Here's a second patch (disregard the first one) fixing all this...

...hopefully ;)

On Friday 15 December 2006 22:43, me, myself, I wrote:
> Hi guys!
>
>
> This afternoon I was testing Squid3 (needed the ICAP-client functionality)
> and it wouldn't start as a virtual-host httpd-accelerator (the -V option on
> the command-line), saying "FATAL: No http_port specified" even though it
> really was specified in the configuration file...
>
> I found out this is because mainParseOptions() is called _before_
> parseConfigFile() in main.cc, so of course Config.Sockaddr.http is NULL
> when handling the -V option. The attached patch fixes this.
>
> Patching that was no big deal, but it's better when it works out of the box
> ;) So here you are, my tiny contribution to the great Squid!
>
>
> Keep up the good work,

-- 
Sébastien Raveau
computer and network security student
head of the hawKeye network monitor project
http://hawkeye.sourceforge.net/