Re: cvs commit: squid3/src ftp.cc

On Mon, 2007-08-13 at 12:01 +0200, Guido Serassio wrote:

> Now fixed.

If you have time, it may be better to replace a virtual
FtpStateData::haveControlChannel(char*) into a static
FtpStateData::HaveControlChannel(FtpStateData*, char*) and let it check
the ftpState pointer itself. This will avoid more code repetition and
may even work faster.

I would also suggest to use a different method name since the code
assumes it is only called to detect attempts to call a method when a
control channel is open. Also, doneWithServer() actually checks for the
presence of both data and control channels.

Thank you,

Alex.
Received on Mon Aug 13 2007 - 10:28:31 MDT