Re: squid3-ipv6 squid3/src ACLIP.cc,1.8.2.45,1.8.2.46

Amos, a little typo:

Acording to original semantics of safe_inet_addr, I think the conditioal
expresion must be positive

SHOULD BE :

> /* dotted notation */
> if (mask = asc)
> return true;
>

Otherwise, acl all src 0.0.0.0 fails to parse....
Up to you the fix.

> Index: ACLIP.cc
> ===================================================================
> RCS file: /cvsroot/squid/squid3/src/ACLIP.cc,v
> retrieving revision 1.8.2.45
> retrieving revision 1.8.2.46
> diff -C2 -d -r1.8.2.45 -r1.8.2.46
> *** ACLIP.cc 21 Sep 2007 12:34:14 -0000 1.8.2.45
> --- ACLIP.cc 24 Sep 2007 02:15:47 -0000 1.8.2.46
> ***************
> *** 205,209 ****
>
> /* dotted notation */
> ! if (safe_inet_addr(asc, mask))
> return true;
>
> --- 205,209 ----
>
> /* dotted notation */
> ! if (!(mask = asc))
> return true;
>
>
Received on Thu Sep 27 2007 - 01:28:24 MDT