Re: ayjwork squid3/src HttpRequestMethod...

On Sat, 2008-02-02 at 13:12 +0000, Amos Jeffries wrote:
> Update of cvs.devel.squid-cache.org:/cvsroot/squid/squid3/src
>
> Modified Files:
> Tag: ayjwork
> HttpRequestMethod.cc HttpRequestMethod.h SquidString.h
> String.cci
> Log Message:
> Compile errors. From HttpRequestMethod class addition.
>
> Test failures are occuring and still need fixing.

Amos,

    I could not tell from the diff what went wrong (too much formatting
noise?). Please let me know if you need any help with HttpRequestMethod
polishing other than the test cases. If am especially worried about
this:

> + #if 0
> + /* AYJ: Duplicated code. Seem an HttpRequestMethod can itself be converted to String() and
> + * this operator clashes with that operator.
> + */
> inline std::ostream &
> operator << (std::ostream &os, HttpRequestMethod const &method)
> ***************
> *** 171,174 ****
> --- 173,177 ----
> return os;
> }
> + #endif

I do not see how HttpRequestMethod can be converted into a String, but
if that is the case, we should probably remove such auto-conversion.

I do not know what error you are getting, but it is possible that
auto-conversion from HttpRequestMethod to method_t is at fault. If so,
we should probably try to remove that conversion.

Again, let me know if you need a hand.

Thank you,

Alex.
Received on Sat Feb 02 2008 - 14:46:56 MST