Re: squid-3.HEAD IPAddress leak

On Thu, 2008-02-07 at 14:08 +0900, Adrian Chadd wrote:
> On Thu, Feb 07, 2008, Robert Collins wrote:
>
> > > Still, this is one of those "death of a thousand cuts" method of
> > > killing performance..
> >
> > Right, I haven't seen the commit; care to mail the diff?
>
> Which? I just looked at the places where Amos is calling GetAddrInfo()
> and FreeAddrInfo(); more then one are:
>
> * GetAddrInfo(temp, );
> * F->{something} = temp;
> * FreeAddrInfo(temp);

Wheee, surely that would be better as
F->{something} = GetAddrInfo(...)

?
-Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.