Re: [Bug 2311] SQUID crashes/ restarts when ICAP enabled on respmod for HTTP body size greater than 100kb

On Thu, 2008-04-17 at 11:54 -0600, Alex Rousskov wrote:

> Short-term: surround the parsing call with try/catch. Handle the parsing
> exception by committing the buffer as if there was no error and aborting
> the transaction. Do it in v3.0 and v3.1. This should be OK because the
> existing parser should not leave the buffer in an inconsistent state.
>
> Long-term: Remove the above hack. Add code to BodyPipe to mark the
> internal buffer as "invalid". Any external access to such buffer would
> result in an exception being thrown. If the checkout object destructor
> catches an exception, it would invalidate the BodyPipe buffer rather
> than letting the exception escape. This would make the checkout process
> exception-safe even in the presence of an externally thrown exception.

Or a much simpler but a little more riskier alternative:

Any-term: Change the semantics of the checkout interface. Make the code
getting access to the buffer responsible for keeping the buffer in a
consistent state at all times. Change ~BodyPipeCheckout action from
pipe.undoCheckOut to pipe.checkIn, with a level 2 warning.

As far as I know, current BodyPipe checkout users obey the rule
suggested above. These users are, essentially, StoreEntry::write and
ChunkedCodingParser::parse.

HTH,

Alex.
Received on Tue Apr 22 2008 - 13:17:14 MDT