Re: client_side and comm_close

On Wed, Apr 16, 2008, Alex Rousskov wrote:

> In short, we have several related problems here: (a) client_side code is
> incapable of reliably identifying whether comm_close has been called;
> (b) ConnStateData::isOpen may not work anymore; (c) client_side code
> uses many different ways to identify whether more data should be read
> from the connection; (d) comm_close is used a lot but no longer has an
> immediate effect and some client_side code may still depend on that
> effect to be immediate; (e) client_side comm handlers decent very deep,
> making it difficult to propagate errors and comm_close status up.
>
> We should decide whether to continue patching holes here and there or
> clean up the client_side*cc connection management mess for good. Should
> we continue to patch isolated v3.0 problems and cleanup v3.1? Or is this
> a v3.2 project? Or am I exaggerating the problems since common cases
> usually work fine?

I'd suggest another option - roll back all of the async calls changes to the
comm code, stabilise the codebase without it and re-evaluate what should
occur (in smaller chunks, rather than dropping in a new comm manager)
before reintroducing it.

I think we've seen that there's still a gap in how development branches are
tested and that the best way we have to test code is to put it in production :)

Adrian

-- 
- Xenion - http://www.xenion.com.au/ - VPS Hosting - Commercial Squid Support -
- $25/pm entry-level VPSes w/ capped bandwidth charges available in WA -