Re: b9173 - fd cleanups

On Tue, 2008-09-09 at 15:27 +1200, Amos Jeffries wrote:
> > On Tue, 2008-09-09 at 00:37 +1200, Amos Jeffries wrote:
> >> http://www.squid-cache.org/Versions/v3/HEAD/changesets/b9173.patch
> >>
> >> Alex, were there any bugs or potential bugs related to this fix? It
> >> rings a small bell in the back of my mind.
> >
> > Yes, we were leaking timeoutHandler and closeHandler call objects
> > (a.k.a., callbacks).
> >
> > No, I do not think there was any corruption going on but that blind
> > memset() in fde::clear() will probably lead to that if not changed or
> > replaced.
> >
>
> Okay, so no related bugzilla entries you are aware of?

Nope, sorry. It was faster for me to fix this particular leak than to
file the bugzilla report and then fix it :-).

I am now testing a lot more changes (affecting several bug reports) and
will post those shortly.

HTH,

Alex.
Received on Tue Sep 09 2008 - 05:27:43 MDT