sendMoreData without connection

Hello,

    Could somebody explain whether the connection can be missing in the
sendMoreData trunk code below, please?

void
clientReplyContext::sendMoreData (StoreIOBuffer result)
{
    if (deleting)
        return;

    StoreEntry *entry = http->storeEntry();

    ConnStateData * conn = http->getConn();

    int fd = conn != NULL ? conn->fd : -1;
    ...

I know that the connection can be in a closing state. In that case, the
new code will simply quit sendMoreData because there is nobody to send
the data to.

I am tempted to do the same for the missing conn case, but it looks like
the old code implies it could be a valid case and sendMoreData should
not quit. Is NULL conn a valid case? If yes, is it appropriate to handle
it by simply returning from the method?

Thank you,

Alex.
P.S. Current USE_ZPH_QOS code in sendMoreData may crash and burn of conn
is missing.
Received on Tue Sep 09 2008 - 17:45:01 MDT