Re: b9250

From: Henrik Nordstrom <henrik_at_henriknordstrom.net>
Date: Thu, 02 Oct 2008 15:53:29 +0200

On tor, 2008-10-02 at 16:04 +1300, Amos Jeffries wrote:
> Henrik,
> did you check my comment about the fatal bug in that patch before
> committing?

No, didn't see that. Sorry.

> if(!vc) ... nameservers[vc->ns] ...
> Will crash with a different more useless trace in the middle of a debug
> context instead of DNS right?

Right.. thanks! That's why it did not stop the segfaults.

The trace is the same. Was crashing on the next line before the patch..
(vc->queue...)

And yes, I forgot that this was a 3.0 branch when merging.

Many errors in that two line merge..

Anyway, all fixed now. New merge request sent so you can review it
first.

Regards
Henrik

Received on Thu Oct 02 2008 - 13:53:36 MDT

This archive was generated by hypermail 2.2.0 : Thu Oct 02 2008 - 12:00:03 MDT