Re: /bzr/squid3/trunk/ r9573: SourceLayout: acl/, take 1

From: Alex Rousskov <rousskov_at_measurement-factory.com>
Date: Tue, 17 Mar 2009 14:37:42 -0600

On 03/17/2009 03:26 AM, Henrik Nordstrom wrote:

> The more I think on this the more I am of the opinion that using
> self-registering static/global objects as method of initialization &
> registration is generally a mistake. Better if each such class have a
> method for initialization, with initialization order explicitly coded in
> the main program. Also makes transition to runtime loaded modules easier
> and less intrusive as each module can assume the modules it registers
> into has been properly initialized already which means it can do a full
> initialization.

I do not want to make any general statements, but the ESI layout patch I
have just posted implements explicit registration of parsers, initiated
by the Esi::Init() call in main.cc.

If somebody is willing to do the equivalent for the ACL code, please
post a patch. The ACL changes are just a little more complex than the
posted ESI changes and the code to be massaged is already isolated in
AclRegs.cc. Meanwhile, I will focus on more pressing issues.

Thank you,

Alex.
Received on Tue Mar 17 2009 - 20:40:11 MDT

This archive was generated by hypermail 2.2.0 : Wed Mar 18 2009 - 12:00:03 MDT