Re: [PATCH] Enhanced access logging, added ICAP logging, bug #2495 fix.

On 07/10/2009 12:26 AM, Amos Jeffries wrote:
>>> adaptation::sum_trs / adaptation::tt
>>
>> These are very different! Tt is a single value while adapt::sum_trs is a
>> list (of individual tr's). Adapt::sum_trs is also symmetric with
>> adapt::all_trs (also a list, but possibly with more entries).
>
> You sure?

I better be!

> I spent a while trying to figure out what all_trs and sum_trs were and
> it looked like all_trs was the list and sum_trs was the single-value sum
> of them.

Here is the relevant documentation which, I believe, is accurate:

<tt Total server-side time in milliseconds. The timer
        starts with the first connect request (or write I/O)
        sent to the first selected peer. The timer stops
        with the last I/O with the last peer.

adaptation_sum_trs Summed adaptation transaction response
                times recorded as a comma-separated list in
                the order of transaction start time. Each time
                value is recorded as an integer number,
                representing response time of one or more
                adaptation (ICAP or eCAP) transaction in
                milliseconds. When a failed transaction is
                being retried or repeated, its time is not
                logged individually but added to the
                replacement (next) transaction. See also:
                adaptation_all_trs.

adaptation_all_trs All adaptation transaction response times.
                Same as adaptation_strs but response times of
                individual transactions are never added
                together. Instead, all transaction response
                times are recorded individually.

Suggestions on how to document these better are welcomed, of course.

> If I did get it wrong, then the tt reduction still applies, but to the
> other option...

Which one? Both adaptation_sum_trs and adaptation_all_trs are *lists*
and not single values like tt. If you mean icap_total_time, then we are
in agreement that it should be spelled icap::tt. I think that is what
Christos has done already.

Thank you,

Alex.
Received on Fri Jul 10 2009 - 14:13:18 MDT