Re: /bzr/squid3/trunk/ r9887: Docs: dstdomain is a 'FAST' group ACL.

Sounds reasonable.

On 8/9/09, Amos Jeffries <squid3_at_treenet.co.nz> wrote:
> Kinkie wrote:
>> On Sun, Aug 9, 2009 at 12:45 AM, Henrik
>> Nordstrom<henrik_at_henriknordstrom.net> wrote:
>>> lör 2009-08-08 klockan 00:44 +1200 skrev Amos Jeffries:
>>>
>>>> Docs: dstdomain is a 'FAST' group ACL.
>>> Actually it's both.. for domain based requests it's fast.
>>>
>>> but for IP based requests it's a slow ACL trying to reverse-lookup the
>>> hostname of the requested ip,
>>
>> Hm.. gah!
>> For documentation purposes it's probably safer to either document this
>> split personality disorder, or to just consider it fast.
>> I checked the code, and it seems "slow" at first glance.
>>
>> For 3.3+ what would you guys think about splitting dstdomain up into
>> two, to make the behaviour clearer? Something like dstname (always
>> fast) and dstdomain (always slow)?
>>
>
> Worst-case;
> adding slow dstrdns which always converts whats given to IP and then
> converts that to rDNS may be a possibility.
> Then making dstdomain a text-only fast match on exactly whats given.
>
> Amos
> --
> Please be using
> Current Stable Squid 2.7.STABLE6 or 3.0.STABLE18
> Current Beta Squid 3.1.0.13
>

-- 
    /kinkie