Re: excessive RAM growth due to unlimited adapted body data consumption

Martin Huter wrote:
> squids ICAP adaptation implementation does not check adapted body-pipes buffer
> size before reading from an ICAP-server.
>
> If the client does not read from the open connection (i.e. the user does not
> confirm the browsers download-message-box in microsofts IE), squid keeps on
> reading data from the ICAP server into the body pipe, whilst no more data
> can be delivered to the client.
> Thus the adapted body pipes buffer is growing unlimited which causes excessive
> RAM growth.
>
> this issue was reported as bugzilla bug 2619 and the attached patch (applies
> to 3.1 and 3.HEAD) should fix the issue.
>
> please review the patch and feel free to comment it.
>
> -----------
>
> i would like to subscribe the squid-dev mailing list.
> my name is martin huter. i'm working as progammer at phion AG in austria.
> i'm mainly working with C and C++ and among others i am responsible for our
> squid service. currently i'm updating squid to version 3.1.
>
> p.s.: many thanks to alex rousskov for his patient help on the appended patch.
>
> cheers
> martin huter
>

+1.

Please remmber to add [PATCH] to the subject of any future patch
submissions for BB to track though.

Amos

-- 
Please be using
   Current Stable Squid 2.7.STABLE6 or 3.0.STABLE18
   Current Beta Squid 3.1.0.13