Re: [PATCH] url_rewrite helper section

From: Henrik Nordstrom <henrik_at_henriknordstrom.net>
Date: Thu, 27 Aug 2009 06:01:12 -0400 (EDT)

hnordstrom has voted tweak.
Status is now: Conditionally approved
Comment:
Looks fine, but could use some minor cleanup like the #if nesting in
include/helper_debug.h.

Also the use of helper_debug() vs debug() seem a little inconsistent.
(the #if added to helpers/ntlm_auth/smb_lm/ntlm_smb_lm_auth.h)

-h option command line processin in the shell helper looks broken as
well... (looks for -d)

For details, see:
http://bundlebuggy.aaronbentley.com/project/squid/request/%3C4A586166.5080001%40treenet.co.nz%3E
Project: Squid
Received on Thu Aug 27 2009 - 10:01:15 MDT

This archive was generated by hypermail 2.2.0 : Thu Aug 27 2009 - 12:00:06 MDT