Re: [PATCH] Log additional header for the navigation from BlackBarry Device

On Tue, Sep 15, 2009 at 8:47 PM, Henrik Nordstrom
<henrik_at_henriknordstrom.net> wrote:
> mån 2009-09-14 klockan 18:58 +0200 skrev devzero2000:
>> I hope this tiny patch can be useful also for other user, so i put
>> here for review and possible merge if you like.
>> Thanks in advance
>>
>> Elia
>> ~~~
>>
>>  This patch permit to log the additional Header used by BlackBarry
>>     and to remove these via http_headers squid.conf directive.
>
> As commented in bugzilla I don't quite see why the patch is needed.
> Logging works equally well without the patch.
>
> Adding header ids for new headers is only useful if you need to quickly
> access these headers in the Squid code. Those header ids are not used by
> the logging code, only the header name.
Sorry. You are quite right, as is evident from the documentation and
code. I made a mistake in my assessment tests, probably because I made
them late at night and in a test environment that it is not complete.

Thanks anyway for your quick reply. I will close the ticket.

> Regards
> Henrik
>
>
Received on Wed Sep 16 2009 - 08:14:35 MDT