Source code formatting bugs

From the #squiddev IRC log:

> (12:13:36 AM) lifeless: amosjeffries: the automated code format stuff is not doing a great job
> (12:13:57 AM) lifeless: e.g. peer_select.cc line 409
> (12:14:10 AM) lifeless: is intended twice as much as it should be
> (12:19:04 AM) amosjeffries: lifeless: noted. oh well. at least its consistent.
> (12:19:33 AM) lifeless: so, I'd like to get rid of the enforcement
> (12:19:38 AM) lifeless: its more trouble than its worth
> (12:23:28 AM) amosjeffries: I disagree, but I'm a bit biased there, since its making my life a bit easier.

I agree with Amos that code formatting should stay because consistent
ugly formatting is better than inconsistent ugly formatting.

We are testing a post-formatting script modification to work around some
of the remaining astyle bugs, including the extra indentation that
Robert mentioned above. I will post when the script is ready (probably
in two weeks). If somebody wants to test and tune that script now,
please ping me and I will assemble and post the current changes.

Thank you,

Alex.
Received on Wed Nov 04 2009 - 16:34:10 MST