Re: /bzr/squid3/trunk/ r10149: skip performing C libTrie unit tests

From: Robert Collins <robertc_at_robertcollins.net>
Date: Sat, 21 Nov 2009 11:41:09 +1100

On Sat, 2009-11-21 at 01:19 +0100, Kinkie wrote:

> > And because the motivation is missing, I'm left asking 'why?' Untested
> > code is broken code, so this really can't be the right answer.
>
> Ok, I'll be more detailed in the future.
> As for this case: the autoconf environment is pretty messy in
> "non-canonicalized" environments such as Solaris. In particular, the C
> tests require linking against libstdc++, which causes two kind of
> issues: finding it (there's at least 6 of the buggers in the test
> zone), and finding the one with the right ABI (gcc/sunstudio cc).
> Since we're not using the C interface anyways, might as well skip the checks.

I'd much rather you delete code that isn't being tested.

-Rob

Received on Sat Nov 21 2009 - 00:41:19 MST

This archive was generated by hypermail 2.2.0 : Sat Nov 21 2009 - 12:00:05 MST