Re: [PATCH] log virgin HTTP request headers

Alex Rousskov wrote:
> ... //< HTTP request headers after adaptation and redirection

There are some magic words here "adaptation and redirection"
OK I did not count the redirection.

So I am posting a new patch which, I hope, satisfy all Amos and Alex
requirements:
  - http::>h always logs the virgin request headers (before
adaptation/redirections)
  - http::>ha logs the request headers after adaptation and redirection.
  - http::>ha is always enabled (even if adaptation is off)

Alex Rousskov wrote:
>......
> * Should we add "virgin" to >h definition in src/cf.data.pre?

Yep

> * I would polish src/cf.data.pre text a little:
>
> [http::]>ha The adapted HTTP request headers.
> Optional header name argument as for >h
OK.

>
>
> * In the first hunk of src/client_side.cc, I would use a single "#if
> USE_ADAPTATION" block to set both aLogEntry->headers.adapted_request and
> aLogEntry->headers.request instead of testing USE_ADAPTATION twice. If
> this is not possible for some reason, ignore me.

There is no USE_ADAPTATION block now

> * Please add comments to document the new adapted_request fields in the
> header files. Something like
>
> ... //< HTTP request headers after adaptation and redirection
>
> may work well.

OK I add some comments

>
>
> Please commit when you are comfortable with the code.

Because I change again the patch I will wait today and if there are no
any objections I will commit it tomorrow.

Regards,
    Christos

>
> Thank you,
>
> Alex.
>
>