Re: [REVIEW] Carefully verify digest responses

From: Alex Rousskov <rousskov_at_measurement-factory.com>
Date: Thu, 04 Mar 2010 20:57:47 -0700

On 03/02/2010 10:06 AM, Henrik Nordstrom wrote:
> First drop of improved digest auth parser.
>
> Focused on the parser & input validation, but as you can see there is
> further room for improvement by moving more processing over to String.
>
> The state of the old parser was rather scary.. not even comparing field
> names correctly and several other ugly things...
>
> Comments are very welcome while I validate the parser changes. Expect to
> submit this for merge in a day or two.

Please consider adding a cppunit test to check a few common and corner
parsing cases.

Cheers,

Alex.
Received on Fri Mar 05 2010 - 03:57:56 MST

This archive was generated by hypermail 2.2.0 : Fri Mar 05 2010 - 12:00:06 MST