Re: [PATCH] TCP logging & UDP Logging - Dhaval Varia

On Thu, Apr 15, 2010 at 6:54 AM, Dhaval Varia <dhavalkvaria_at_gmail.com> wrote:
> Dear Sir,
>
> Please find the attached patch file for the
>
> 1. TCP logging (Newly created)   ------- modtcp.patch

The patch is not malformed now. I still don't understand the
file-related error messages, so I leave this to someone with more clue
than I do.

> 2. UDP logging (Modified)  ------- modudpfix.patch

The test reversal seems fine. +1 (I don't understand why adding the
four empty lines in logfile_mod_udp_open(); it clashes with Squid's
coding style guidelines.)

> would you please commit this TCP logging and UDP fix first??
>
> I will see what to do to handle back pressure later.

Ok by me. It's probably implicitly done if the socket is blocking.

-- 
    /kinkie