Re: [3.1] drop split-stack and V6ONLY magics

From: Henrik Nordström <henrik_at_henriknordstrom.net>
Date: Sat, 15 May 2010 23:22:30 +0200

lör 2010-05-15 klockan 22:47 +1200 skrev Amos Jeffries:

> I think we should retain a test for existence of IPV6_V6ONLY though. It
> can be a if-compiles and will catch the WindowsXP etc cases.

Why? If IPV6_ONLY is there then the code will always request it to be
disabled.

> The .cc/.h changes need some text fixes:
> "caouse trobles" => "cause trouble"

Right.

> "Windows Vista" => "Windows Vista and later"

OK, I'll fix that in both original and new copy..

> new level-0 debugs() calls also need to use DBG_CRITICAL instead of
> magic number so we can find them again easily.

Didn't add any, just filtered an existing one.. but can fix that.

New version attached. Also fixed a trivial bug next to that debugs
statement,, (warned = 0 should be 1...)

Regards
Henrik

Received on Sat May 15 2010 - 21:22:35 MDT

This archive was generated by hypermail 2.2.0 : Sun May 16 2010 - 12:00:08 MDT