Re: Log all transactions?

From: Amos Jeffries <squid3_at_treenet.co.nz>
Date: Mon, 28 Jun 2010 23:54:15 +0000

On Mon, 28 Jun 2010 12:17:16 -0600, Alex Rousskov
<rousskov_at_measurement-factory.com> wrote:
> Hello,
>
> What is the motivation behind excluding HTTP transactions with
> LOG_TAG_NONE logType and zero out.size?

Maybe protecting the access.log from SYN-floods of ICP spam.

>
>> void
>> ClientHttpRequest::logRequest()
>> {
>> if (out.size || logType) {
>
> This guard might keep valuable information from the cache administrator.
> Should we work on removing the guard?

+1.
I suspect it will result in uncovering some error pathways which can be
short-circuited a lot earlier than logging. If not then it's probably
useless.

Amos
Received on Mon Jun 28 2010 - 23:54:20 MDT

This archive was generated by hypermail 2.2.0 : Tue Jun 29 2010 - 12:00:07 MDT