Re: Note about auth refcounting state / ntlm in trunk

mån 2010-08-16 klockan 18:15 +1200 skrev Amos Jeffries:

> So...... the difference being that you are suggesting the credentials
> text and parsing should be done on AuthUserRequest and no AuthUser
> should exist associated with it until fully authed?
> AuthUser only created/looked up at the point currently doing absorb()?

Correct.

> Sounds like a good plan.
> NOTE: this is why I specifically asked for details on the
> RefCountCount() value on the assert bug:

==2 I think. Looks up IRC logs.. yes. "from->RefCountCount() == 2"

> > AuthUser should be scheme-independent, but need to softly link to the
> > schemes using it allowing clean garbage collection and association of
> > scheme state (basic credentials cache, confirmed digest nonces and their
> > related H(A1))
>
> It is already like that. AuthUser is the mostly-private part persisting
> across requests/conn in the username cache. AuthUserRequest is the
> public hanging off each request and conn indicating state of auth.
> Pointing to whatever AuthUser has the credentials text.

Almost.. each AuthUser is scheme specific today. Shouldn't be, but still
is. Not the class as such, but it's data makes it unique per scheme.
References auth_type and AuthConfig.

Regards
Henrik
Received on Mon Aug 16 2010 - 08:35:49 MDT