Re: [PATCH] Compliance: handle HTTP OPTIONS and TRACE requests with asterisk URIs

On Tue, 31 Aug 2010 03:49:26 +0000, Amos Jeffries <squid3_at_treenet.co.nz>
wrote:
> On Mon, 30 Aug 2010 19:33:39 -0600, Alex Rousskov
> <rousskov_at_measurement-factory.com> wrote:
>> Compliance: handle HTTP OPTIONS and TRACE requests with asterisk URIs.
>>
>> Handle '*' URIs in urlParse(). This allows Squid properly respond to
>> OPTIONS and TRACE requests with '*' URIs and Max-Forwards value of
zero.
>
>> Forwarding similar requests with positive Max-Forwards value is out of
>> this change scope and still does not work, because the upstream host
and
>
>> port are not set.
>>
>> Co-Advisor test cases:
>> test_case/rfc2616/options-bodyless-asterisk
>> test_case/rfc2616/maxForwardsZero-OPTIONS-asterisk
>> test_case/rfc2616/maxForwardsZero-TRACE-asterisk
>
>
> * The purpose of urlCheckRequest(request) is to determine if the request
> is servicable and should be updated to contain the condition:
>
> if ((method == METHOD_TRACE || method == METHOD_OPTIONS) &&
> (request->max_forwards == 0 && request->urlpath == "*"))
> return 1;

oops, should be return 0.

Amos
Received on Tue Aug 31 2010 - 04:06:03 MDT