Re: [MERGE] Initial netfilter mark patch for comment

<snip>
> > The above configure concept would tie in with removing the --enable-qos
> > option altogether. There's no reason for the QOS code not to be included
> > that I can see (it has no dependencies, apart from the optional upstream
> > kernel patch), and with this patch and the isTosActive(), it's enabled
> > at runtime only when needed anyway. Is there any reason to keep the
> > option?
>
> This argument has bee put forward for other small features. Sometimes it
> succeeds, sometimes not. I know that a mere 1KB saving on binary size
> can be extremely useful for embeded devices so the option is likely to
> be wanted by somebody.

Understood. With the patch in its current format though, I have removed
a lot of the #if statements (based on previous feedback) and replaced
with is*Active() statements.

I'll send the patch through shortly and you can see what you think in
its current state.

Andy
Received on Sun Sep 05 2010 - 07:01:24 MDT